Feat: Animation system with view management enhancements

Geometry documents/AUDIT-2026-02-10.md

@@ -0,0 +1,155 @@
+# Code Quality Audit Report
+
+**Date:** 2026-02-10
+**Auditor:** Claude Code (Opus 4.6)
+**Audit Type:** Minor (post-feature, Animate branch)
+**Branch:** Animate
+
+---
+
+## Executive Summary
+
+**Overall Status:** ⚠️ PASS WITH WARNINGS
+
+**Files Audited:** 2 JS files (`rt-animate.js`, `rt-viewmanager.js`)
+**Issues Found:** 8 total (0 critical, 3 high, 3 medium, 2 low)
+**Auto-Fixed:** 9 Prettier formatting violations
+**Manual Action Required:** 3 items (duplication refactoring + inline style migration)
+
+---
+
+## Section 1: Automated Checks
+
+### Prettier Formatting
+
+- **Status:** ✅ PASS (after auto-fix)
+- **Violations:** 2 files (9 formatting errors)
+- **Auto-Fixed:** Yes — `npx prettier --write`
+
+### ESLint Compliance
+
+- **Status:** ✅ PASS
+- **Errors:** 0
+- **Warnings:** 0
+- **Notes:** All 9 initial errors were prettier/prettier formatting — resolved by Prettier auto-fix
+
+### Performance
+
+- **Status:** ⏭️ SKIPPED (manual browser test — user can verify 60fps)
+
+---
+
+## Section 2: Manual Review Findings
+
+### Code Quality
+
+#### Duplicate Functions: 2 found
+
+1. **`previewAnimation()` vs `previewAnimationFull()`** — rt-animate.js:231 / rt-animate.js:282
+   - **Severity: HIGH** — 45-line functions that are ~90% identical
+   - Only difference: calls `animateToView()` vs `animateToViewFull()`
+   - Identical stop block (12 lines), identical resume-from-last logic (5 lines), identical main loop (10 lines)
+   - **Fix:** Extract shared `_runPreviewLoop(animateFn, updateBtn)` method
+
+2. **`_updatePreviewButton()` vs `_updatePreviewFullButton()`** — rt-animate.js:335 / rt-animate.js:353
+   - **Severity: MEDIUM** — 95% identical, differ only by element ID and title text
+   - **Fix:** Consolidate into `_updatePlayStopBtn(elementId, playing, titles)`
+
+#### Inline Styles (violates user preference): 4 occurrences
+
+- rt-animate.js:339-340, 343-344, 357-358, 361-362
+- **Severity: MEDIUM** — Play/stop button HTML contains `style="color: #ff6b6b; font-size: 14px"`
+- User explicitly requested: "keep any/all css not inline but in @art.css"
+- **Fix:** Add `.anim-icon-stop` and `.anim-icon-play` classes to art.css
+
+#### Verbose Functions (>50 lines): 4 found
+
+| Function | File | Lines | Count | Verdict |
+|---|---|---|---|---|
+| `animateToView()` | rt-animate.js:57 | 57–153 | 97 | Acceptable — core animation loop |
+| `exportAnimation()` | rt-animate.js:438 | 438–532 | 95 | Acceptable — frame generation |
+| `animateToViewFull()` | rt-animate.js:164 | 164–223 | 60 | Acceptable — cutplane orchestration |
+| `_setupDragReorder()` | rt-viewmanager.js:1730 | 1730–1793 | 63 | Acceptable — 5 event handlers, well-guarded |
+
+#### Dead Code: 0 blocks found ✅
+#### Commented-Out Code: 0 blocks found ✅
+
+### Console Statements
+
+| File | Count | New on Animate? | Verdict |
+|---|---|---|---|
+| rt-animate.js | 1 (`console.warn`) | Yes | ✅ Acceptable — validation warning |
+| rt-viewmanager.js | 12 (`console.log`) | 0 new | Existing — not in audit scope |
+
+### Magic Numbers: 3 noted
+
+1. **`3 - 2 * rawT`** (rt-animate.js:113, 485) — Smoothstep easing formula. Well-known, comment present ("smoothstep"). ✅ Acceptable
+2. **`duration / 3`** (rt-animate.js:270, 321) — Hold time = 1/3 of transition. No comment explaining ratio. **Low priority**
+3. **`max="24"`** (rt-viewmanager.js:1829) — Max slider value 24 seconds. No comment. **Low priority**
+
+---
+
+## Section 3: RT-Purity Analysis
+
+### Classical Trigonometry Usage
+
+- **Total Occurrences in audited files:** 0
+- **Math.PI:** 0 ✅
+- **Math.sin/cos/tan:** 0 ✅
+- **Math.asin/acos/atan:** 0 ✅
+
+### Deferred √ Expansion
+
+- **Violations Found:** 0 ✅
+- The animation system works with camera position vectors (THREE.js boundary), no RT calculations present
+
+### Golden Ratio Identity Usage
+
+- **Not applicable** — Animation module doesn't use φ calculations
+
+**RT-Purity: ✅ CLEAN** — No classical trig in either file.
+
+---
+
+## Section 4: Action Items
+
+### High Priority (Fix during audit)
+
+1. **Refactor preview duplication** — rt-animate.js:231–327
+   - Extract shared loop into `_runPreviewLoop(animateFn, updateBtnFn)`
+   - Eliminates ~40 lines of duplicate code
+
+2. **Consolidate button update functions** — rt-animate.js:335–365
+   - Merge into single `_updatePlayStopBtn(id, playing, titles)`
+   - Eliminates ~15 lines of duplicate code
+
+3. **Move inline styles to art.css** — rt-animate.js:339–362
+   - Add `.anim-icon-stop` / `.anim-icon-play` classes
+   - Consistent with user's stated CSS preference
+
+### Low Priority (Backlog)
+
+4. **Add comment for hold-time ratio** — rt-animate.js:270
+5. **Add comment for slider max** — rt-viewmanager.js:1829
+
+---
+
+## Section 5: Quality Gate Assessment
+
+| Gate | Target | Actual | Status |
+|---|---|---|---|
+| ESLint Errors | 0 | 0 | ✅ |
+| Prettier Violations | 0 | 0 (after fix) | ✅ |
+| Performance (60fps) | 16.67ms | Skipped | ⏭️ |
+| Duplicate Functions | 0 | 2 | ⚠️ |
+| Classical Trig (%) | < 5% | 0% | ✅ |
+
+**Overall:** ⚠️ PASS WITH WARNINGS — Duplication and inline styles need refactoring
+
+---
+
+## Section 6: Recommendations
+
+1. **Consolidate preview loop logic** — The two preview functions share a `_stopPreview()` teardown and a `_runPreviewLoop()` core. Extracting both would reduce rt-animate.js by ~55 lines.
+2. **CSS class convention** — All animation UI elements should use CSS classes in art.css, not inline styles.
+3. **No architectural concerns** — Module boundaries are clean. `rt-animate.js` correctly delegates scene state to `rt-viewmanager.js` and only handles camera interpolation directly.

Geometry documents/Animations.md

@@ -629,9 +629,10 @@ if __name__ == '__main__':
 | **5a** | `rt-viewmanager.js` | Drag-to-reorder rows (grip handle) | Drag view between others, verify order persists | Pending |
 | **5b** | `rt-viewmanager.js`, `rt-animate.js` | Object visibility per view (instanceRefs) | Add/remove polyhedra between views, verify dissolve | Pending |
 | **5c** | `rt-papercut.js` | Papercut respects opacity=0 as invisible | Zero-opacity objects excluded from section cuts | Pending |
-| **6a** | `index.html` | Dual-row UI: "Camera" / "Camera + Scene" labels + buttons | Both rows visible, distinct labels | Pending |
-| **6b** | `rt-viewmanager.js` | `loadViewState()` with `skipCamera` option | Restores non-camera state only | Pending |
-| **6c** | `rt-animate.js` | `animateToViewFull()` + `previewAnimationFull()` | Bottom-row ▶ restores cutplanes at arrival | Pending |
+| ~~**6a**~~ | `index.html` | ~~Dual-row UI: "Camera" / "Camera + Scene" labels + buttons~~ | ~~Both rows visible, distinct labels~~ | **DONE** `a106bf7` |
+| ~~**6b**~~ | `rt-viewmanager.js` | ~~`loadView()` with `skipCamera` option~~ | ~~Restores non-camera state only~~ | **DONE** `a106bf7` |
+| ~~**6c**~~ | `rt-animate.js` | ~~`animateToViewFull()` + smooth cutplane interpolation~~ | ~~Bottom-row ▶ slerps camera + interpolates cutplane~~ | **DONE** `a106bf7` |
+| ~~**6d**~~ | `index.html` | ~~HTML reorg: Move View Capture → "View Manager" section, rename Camera → View Manager~~ | ~~UI layout correct, all controls functional~~ | **DONE** |
 
 ## Favicon-Specific Parameters
 
@@ -799,17 +800,30 @@ This requires a `loadViewState()` variant in ViewManager that can selectively re
 
 ---
 
-## Known Bugs
+## Future Refinements
+
+### Bidirectional Cutplane Transitions
+
+Currently `animateToViewFull()` interpolates the cutplane value between two views that share the same axis. When transitioning from a view with **no cutplane** to one **with a cutplane** (or vice versa), the transition should be bidirectional:
+
+- **Entering a cut** (no cut → cut at interval *d*): Enable the cutplane at the far edge (or distance 0), then smoothly slide it to position *d* over the transition duration. The cut "sweeps in" from the boundary.
+- **Exiting a cut** (cut at interval *d* → no cut): Smoothly slide the cutplane back to the far edge / distance 0, then disable. The cut "recedes" before disappearing.
+
+This makes cutplane transitions feel physically motivated — the plane always arrives from or departs to a natural boundary rather than popping on/off. Implementation would extend the `onTick` callback in `animateToViewFull()` to detect the no-cut ↔ cut transition case and remap the interpolation range accordingly (e.g. `lerp(edgeDistance, targetValue, t)` instead of `lerp(0, targetValue, t)`).
 
-### BUG: Cutplane state not restoring on ▶ transitions
+### Expandable View List (No Scrollbar)
 
-**Symptom**: Section cut state (cutplane on/off, position) used to toggle correctly when switching between views via ▶. If View 1 had no section cut and View 2 did, clicking ▶ on each would show/hide the cut. This was lost when ▶ was changed from `loadView()` (full state restore) to `animateToView()` (camera-only).
+The Saved Views table currently has `max-height: 150px; overflow-y: auto`, which produces a scrollbar when the list grows. This doesn't match the UI's scroll-free aesthetic. Instead, remove the `max-height` constraint and let the view list expand naturally within the collapsible section. The user already scrolls the full sidebar panel — an inner scrollbar is redundant and visually inconsistent. This becomes especially important once drag-to-reorder handles (Phase 5a) are added, where seeing the full list is essential for reordering across many views (20-50+).
+
+---
+
+## Known Bugs
 
-**Root cause**: The ▶ delegation in `rt-viewmanager.js` now calls `RTAnimate.animateToView()` which only interpolates camera position/zoom — it does not call `loadView()` and therefore does not restore cutplane, projection, or object visibility state.
+### ~~BUG: Cutplane state not restoring on ▶ transitions~~ — RESOLVED `a106bf7`
 
-**Resolution**: Phase 6 dual-row UI. The top-row ▶ is correctly camera-only. The bottom-row ▶ calls `animateToViewFull()` which restores non-camera state at animation completion. Users who need cutplane toggling use the bottom row.
+~~**Symptom**: Section cut state (cutplane on/off, position) used to toggle correctly when switching between views via ▶.~~
 
-**Priority**: Resolved by design in Phase 6.
+**Resolution**: Phase 6 dual-row UI. Top-row ▶ is camera-only by design. Bottom-row ▶ calls `animateToViewFull()` which smoothly interpolates the cutplane value per frame and snaps remaining scene state at arrival. Exceeded original fix — cutplane now *animates* between views rather than snapping.
 
 ---