Conversation
- Add _setupDissolve() in rt-animate.js: smooth opacity fade between views based on instanceRefs, with mid-cancel cleanup via material markers - Integrate dissolve into animateToViewFull() alongside cutplane interpolation - Add instance visibility snap in loadView() using group.visible - Add opacity===0 guard in rt-papercut.js to exclude dissolved-out objects from section cuts - Add same guard to extractEdgeLines() and extractMeshFaces() for SVG export 🤖 Co-Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Andy🤦♂️ & Claude🤖 <andy@openbuilding.ca>
🤖 Co-Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Andy🤦♂️ & Claude🤖 <andy@openbuilding.ca>
New rt-delta.js module captures/diffs/applies/interpolates scene state: - captureSnapshot() reads checkboxes, sliders, projections from DOM - computeDelta() shallow-diffs two snapshots, stores only changes - applyDelta() restores state through existing UI handlers + updateGeometry() - buildSteppedTick() returns onTick(t) for animated transitions: integer sliders step through values, floats interpolate smoothly, projections snap at midpoint Integration: - captureView() now stores view.sceneState (delta vs previous view) - loadView() applies accumulated snapshot for instant scene restore - animateToViewFull() merges delta tick with cutplane + dissolve ticks 🤖 Co-Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Andy🤦♂️ & Claude🤖 <andy@openbuilding.ca>
…igation note
_setSlider() now fires dispatchEvent('input') so scale/opacity handlers
respond during animated transitions. Added TO BE INVESTIGATED section
in Animations.md for per-polyhedron scale capture beyond global/tet sliders.
🤖 Co-Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Andy🤦♂️ & Claude🤖 <andy@openbuilding.ca>
…TODOs Discrete integer sliders (geodesic freq, helix count) now use linear rawT for even step spacing instead of smoothstepped t which bunched steps at the midpoint. Continuous sliders (scale, opacity) keep smoothstep easing. Updated Animations.md: 5b marked DONE, added TODOs for smoother mesh rebuild transitions and scene state preview in Saved Views table. 🤖 Co-Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Andy🤦♂️ & Claude🤖 <andy@openbuilding.ca>
Per-row ▶ buttons now use animateToViewFull() for full scene transitions (camera + forms + sliders), not just camera-only. Base forms fade in/out smoothly via dissolveOpacity on group.userData, read by renderPolyhedron() when creating fresh materials each frame. 🤖 Co-Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Andy🤦♂️ & Claude🤖 <andy@openbuilding.ca>
Replaced 11 raw console.log calls with MetaLog.log() at appropriate levels: - Close-pack RT diagnostics → DETAILED - Geodesic/tiling edge Q scaling → DETAILED - Matrix/radial node counts → SUMMARY - Close-pack unavailable warning → SUMMARY (warn) 🤖 Co-Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Andy🤦♂️ & Claude🤖 <andy@openbuilding.ca>
🤖 Claude Code ReviewNo issues found. ℹ️ About this reviewThis automated review checks for:
Human review required - these are suggestions only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rt-delta.js) captures, diffs, applies, and interpolates view statesChanges
modules/rt-delta.js(new) — Scene state delta module:captureSnapshot(),computeDelta(),applyDelta(),buildSteppedTick()with rawT for integer sliders, smoothstepped t for floatsmodules/rt-animate.js— Instance dissolve (_setupDissolve), form dissolve (_setupFormDissolve+_CHECKBOX_TO_GROUPmap +_cleanupFormDissolve), merged onTick with cutplane/dissolve/delta ticksmodules/rt-viewmanager.js—captureView()stores scene deltas,getSnapshotAtView()accumulates snapshots,loadView()applies full accumulated state, per-row ▶ usesanimateToViewFull()modules/rt-rendering.js—renderPolyhedron()readsgroup.userData.dissolveOpacityand applies to face/edge/node materialsmodules/rt-papercut.js— Skips dissolved-out objects (opacity=0) during section cutsmodules/rt-nodes.js— 11 rawconsole.logcalls replaced withMetaLog.log()at SUMMARY/DETAILED levelsGeometry Documents/Animations.md— Phase 5b marked DONE, TODOs for smoother mesh rebuilds and scene state previewTest plan
?logLevel=detailedrestores diagnostic output🤖 Generated with Claude Code
Co-Authored-By: Andy🤦♂️ & Claude🤖 andy@openbuilding.ca