Feat: Player Piano demo reel + animation state persistence fixes

[arossti]

Summary

• Player Piano demo reel generator (18-view scripted tour of primitives, platonics, geodesics, tetrahelixes incl. octahedral fireworks)
• Complete animation state persistence for matrices and tetrahelix3
• Matrix dissolve opacity pipeline fix
• Camera slerp fix at Z poles

Changes

Player Piano (scripts/PlayerPiano-generator.js — gitignored)

• 18-view demo reel: 3 primitives, 5 platonics, 4 geodesics, 6 tetrahelixes (incl. octahedral Tetrahelix3 "fireworks" bloom)
• Close-up camera framing throughout, pulls back only for ensemble/torus views

State Persistence Fixes (rt-delta.js, rt-filehandler.js)

• Matrix sub-controls (9326f11): 5 rotate45 toggles, 10 matrix sub-control panels, slider display text — all added to delta capture + filehandler export/import
• Radial mode toggles (66de343): radialCubeSpaceFill, radialTetIVMMode, radialOctIVMScale added to full persistence pipeline
• Tetrahelix3 (e3a7add): showTetrahelix3 + 8 strand toggles + 8 chirality toggles added to delta capture; sub-control panel mapping added
• Double updateGeometry() (66de343): Removed redundant explicit call in buildSteppedTick() — slider dispatch already triggers rebuild

Rendering (rt-rendering.js)

• Matrix dissolve opacity (66de343): All 10 matrix creation blocks (5 planar + 5 radial) now read group.userData.dissolveOpacity and compute effectiveOpacity before passing to matrix creators

Camera (rt-animate.js — prior commit)

• Slerp torque at Z poles (bfc1a1c): Proper angle-based slerp for direction interpolation + interpolated up vector

Documentation (Animations.md)

• Matrix animation known limitation documented with short/medium/long-term pipeline
• Matrix dissolve opacity optimization workplan (skip rebuilds for opacity-only ticks)
• All resolved bugs documented with commit hashes

Test plan

• 18-view demo reel generates and plays back with smooth dissolves
• Tetrahelix3 octahedral fireworks visible in playback (was blank before delta fix)
• Radial matrix mode toggles (Space Filling / IVM) persist across save/load
• Matrix 45° rotation + size slider + sub-control panels persist
• Camera transitions smooth through Z-pole presets
• Verify no regressions in manual view creation/editing workflow

🤖 Generated with Claude Code

Co-Authored-By: Andy🤦‍♂️ & Claude🤖 andy@openbuilding.ca

[github-actions]

🤖 Claude Code Review

Looking through the diff and file contents, here's what I found:

Code Quality Issues

1. Unused variables

• File: modules/rt-animate.js
• Location: Line 436 in exportAnimation() function

const endZoom = to

This variable declaration is incomplete/cut off at the end of the file, suggesting the code may be truncated or there's a syntax error.

2. Large function

• File: modules/rt-animate.js
• Function: animateToView() (lines 42-146)
• Length: 104+ lines
• This function handles camera animation setup, state management, position/rotation interpolation, and animation loop control. Consider extracting smaller functions for:
  • Camera state capture and target computation
  • Slerp interpolation logic
  • Animation tick handling

3. Large function

• File: modules/rt-animate.js
• Function: _setupFormDissolve() (lines 417-527)
• Length: 110+ lines
• This function handles form dissolve animation setup with cleanup, target identification, pre-animation setup, and tick callback creation. Consider breaking into smaller focused functions.

4. Code duplication

• File: modules/rt-animate.js
• Lines: 598-611 and 613-626

_updatePlayStopBtn(
  "previewAnimationBtn", 
  playing,
  "Stop animation preview",
  "Preview animation loop in scene"
);

_updatePlayStopBtn(
  "previewFullBtn",
  playing, 
  "Stop full-scene animation preview",
  "Preview with full scene restore (cutplane, render state)"
);

These two functions (_updatePreviewButton and _updatePreviewFullButton) follow identical patterns and could be consolidated into a single parameterized function.

No issues found.

---

ℹ️ About this review

This automated review checks for:

• Debug statements (console.log)
• Commented-out code
• Code duplication
• Large functions (>50 lines)
• Unused variables

Human review required - these are suggestions only.
Diff size: 79967 bytes