Codescanning fix march8 #59
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| os.makedirs(save_path, exist_ok=True) | ||
| with open(os.path.join(save_path, "config.json"), "w") as f: | ||
| with open(f"{save_path}/config.json", "w") as f: |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 months ago
To fix the problem, we need to validate and sanitize the user-provided aml_dataset before using it to construct the file path. We can use os.path.normpath to normalize the path and ensure it does not contain any malicious segments. Additionally, we can check that the resulting path is within a safe root directory.
- Normalize the
aml_datasetvalue usingos.path.normpath. - Ensure that the normalized path does not contain any segments that could lead to directory traversal.
- Construct the
experiment_idandsave_pathusing the sanitizedaml_dataset.
Suggested changeset
1
Solution_Accelerators/Advanced_RAG/src/evals/rag_eval/__main__.py
| @@ -174,3 +174,5 @@ | ||
| current_time = pd.Timestamp.now().strftime("%Y-%m-%d_%H%M%S") | ||
| aml_dataset = parsed_config.aml_dataset | ||
| aml_dataset = os.path.normpath(parsed_config.aml_dataset) | ||
| if os.path.isabs(aml_dataset) or ".." in aml_dataset.split(os.path.sep): | ||
| raise ValueError("Invalid aml_dataset value.") | ||
| experiment_id = f"RAG-Bot-Eval_Dataset_eq_{aml_dataset}_Start_eq_{current_time}" |
Copilot is powered by AI and may make mistakes. Always verify output.
| @@ -719,14 +713,11 @@ | |||
|
|
|||
| combined_results = { | |||
| "config": config.__dict__, | |||
| "metrics": json.load(open(os.path.normpath(os.path.join(current_dir, "results", config.experiment_id, "run_metrics.json")))), | |||
| "answers": pd.read_csv(os.path.normpath(os.path.join(current_dir, "results", config.experiment_id, "run_details.csv"))).to_dict(), | |||
| "metrics": json.load(open(f"{current_dir}/results/{config.experiment_id}/run_metrics.json")), | |||
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| json.dump( | ||
| combined_results, open(metrics_path, "w"), indent=4 | ||
| combined_results, open(f"{current_dir}/results/{config.experiment_id}/combined_results.json", "w"), indent=4 |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information