Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored into typescript #623

Closed
wants to merge 11 commits into from
Closed

refactored into typescript #623

wants to merge 11 commits into from

Conversation

capaj
Copy link

@capaj capaj commented Feb 23, 2019

this is probably not going to get merged, but what the heck-if there is a slim chance let's try at least.

I've rewritten the codebase to typescript. Next on the roadmap would be to get rid of react-onclickoutside as a dependency.

I will try to bring in the latest changes from the upstream and then I'll mark as ready for code review.

@arqex
Copy link
Owner

arqex commented Sep 19, 2020

Hey @capaj this is one of the most fabulous PR this libraries had ever had!

I'm arriving late to it, and now it's too late to start merging it. One of the ambitions for v4 is to port the source to typescript, so I won't close this PR in case we can salvage some of this work for the new version.

In that new version we are looking for more people to collaborate, and since you already know about the internals of react-datetime, it would be a pleasure if you can add your 2 cents to the roadmap of the new version:

#723

Thanks so much for your effort.

@capaj capaj closed this Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants