Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added openjdk8 to .travis.yml #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added openjdk8 to .travis.yml #41

wants to merge 1 commit into from

Conversation

krichter722
Copy link

Short description of what this resolves:

Test might fail with OpenJDK while they pass with Oracle JDK.

Changes proposed in this pull request:

  • Testing everything with OpenJDK8 that is tested with Oracle JDK 8 on Travis CI

@bartoszmajsak
Copy link
Member

Thanks for your contribution. Makes me wonder if we really need tests on both JDKs (OpenJDK and Oracle). What would be the benefit @krichter722?

@krichter722
Copy link
Author

Thanks for your contribution. Makes me wonder if we really need tests on both JDKs (OpenJDK and Oracle). What would be the benefit @krichter722?

I started investigating an issue and suspected it to be related to OpenJDK (strange stack in a GlassFish version I don't recall, but it's not important) and wanted to see whether devs are aware of eventual OpenJDK and Oracle JDK differences which might not influence arquillian-container-glassfish. However, testing both (in parallel without much slowdown) prevents unnecessary wondering. Now, I'm sharing this without thinking that there's a large number of use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants