-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Glassfish6 container to a glassfish6 branch #12
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
…as artifiact Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
@starksm64 I am not sure why this repo is under It seems the build failure is related to it - it cannot clone the repo with this org assigned. Can you try to push a commit - I changed the config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this improvement @starksm64. I have just a few questions.
And one little ask in addition - can README.txt
be converted to markdown, or better yet, asciidoc? :)
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Ok, CI is back to passing |
Is it intended to be a support branch with not so many changes in the future or do we expect merging back stuff from ongoing development? If the latter it might be good to think about the approach here (ideally automatic). |
I expect very little ongoing development in this glassfish6 branch. |
Merge this PR to upstream glassfish6(not master) branch and release a preview for Glassfish 6. |
Short description of what this resolves:
Move the current GlassFish6 container into a glassfish6 branch
Changes proposed in this pull request:
Save the current GlassFish6 work
Incorporate #7
Update artifacts to remove GlassFish version as per #8
Fixes #
#8