Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for executing CDI Lite extensions. Upgrade Weld to version 5 #114

Merged
merged 2 commits into from
Nov 30, 2021

Conversation

manovotn
Copy link
Contributor

Fixes #113

Upgrades Weld API and impl to version 5.
Introduces support for new CDI Lite extensions - since this container bootstraps Weld on its own, it also needs to register newly added portable extension through which we execute build compatible extensions.

We'll again need a release with this to be able to bump it on Weld side and test CDI TCK with this container (after jakartaee/cdi-tck#312 is merged).

@manovotn manovotn requested a review from starksm64 November 29, 2021 21:01
@manovotn
Copy link
Contributor Author

Actually, let me put this back to Draft state. I am thinking of one more needed fix.

@manovotn manovotn marked this pull request as draft November 29, 2021 21:10
@manovotn
Copy link
Contributor Author

Also, the CI failure is because the Weld module is compiled with min level set to JDK 11.
I am not sure that is something we want/need or if we even care for 8 - personally I think we could drop it since EE 10 is going to be baseline 11 anyway.

@manovotn
Copy link
Contributor Author

manovotn commented Nov 30, 2021

Actually, let me put this back to Draft state. I am thinking of one more needed fix.

I wanted to look into Weld bootstraps how to tweak that WRT custom stereotypes but turns out there isn't much I could do now (it is limited by code in Weld core).
Therefore, I'll put this back on ready for review.

I'll also add a commit that removes JDK 8 from the matrix of CI JDK versions on the basis of EE 10 requiring it anyway.

@manovotn manovotn marked this pull request as ready for review November 30, 2021 08:54
@starksm64 starksm64 merged commit 5d3b1da into arquillian:master Nov 30, 2021
@manovotn manovotn deleted the issue113 branch November 30, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide support for build compatible extensions in CDI Lite
2 participants