Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switches to Jakarta EE 9 APIs #66

Merged
merged 8 commits into from
Apr 28, 2020

Conversation

starksm64
Copy link
Member

Signed-off-by: Scott M Stark starksm64@gmail.com

Short description of what this resolves:

Update packages in Jakarta EE 9 that have changed from javax to jakarta

Changes proposed in this pull request:

  • initial update of package names.

Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
starksm64 and others added 3 commits April 20, 2020 09:35
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
@bartoszmajsak
Copy link
Member

@starksm64 @manovotn Arquillian Core 1.7.0.Alpha1 is available in Maven Central.

@manovotn
Copy link
Contributor

@bartoszmajsak thanks! This PR is already updated with it :)

@bartoszmajsak
Copy link
Member

@bartoszmajsak thanks! This PR is already updated with it :)

I noticed after I hit "comment" :) Need more coffee :)

@manovotn
Copy link
Contributor

Updated Weld to 4.0.0.Alpha1, this makes the CI pass.
@bartoszmajsak do you think you could release this, please?

@bartoszmajsak
Copy link
Member

@bartoszmajsak do you think you could release this, please?

@manovotn Sure, I will do that today. Just one final question - are we going with 2.2.0.Final or Alpha1?

@manovotn
Copy link
Contributor

manovotn commented Apr 27, 2020

@bartoszmajsak why 2.2.0? Last release was 2.0.1. It should IMO be version 3.0.0 - we might still need to maintain 2.x for older version. And I wouldn't go for Final just yet, not until we know if there are more changes needed wrt EE 9. Does that make sense?

@bartoszmajsak
Copy link
Member

Right, I meant 2.1.0.Final but you are right, it's entire switch to new APIs, so I think we should bump to 3.0.0.Alpha1. Thx for clarifications.

@manovotn
Copy link
Contributor

BTW the PRs made by dependabot against this repo are pretty much superseeded by this one.

@bartoszmajsak
Copy link
Member

BTW the PRs made by dependabot against this repo are pretty much superseeded by this one.

Which ones? Those for Weld I won't merge, but I would like to cut 2.x release first before releasing this one to have a bit more up-to-date version in case we need to support both.

@manovotn
Copy link
Contributor

Yeah, I meant primarily weld/cdi api upgrades.
This one #62 is IMO swap from java EE to jakarta EE (still on EE 8). So that should be safe to include.
This one #51 I am not sure about

@bartoszmajsak
Copy link
Member

Yeah #51 is quite a cryptic version bump :) I will close it. As for #62 - if that's backward compatible then sure, I will merge that before cutting 2.1.0.Final and then merging this one.

@bartoszmajsak
Copy link
Member

@manovotn I will resolve conflicts, don't worry about that.

@bartoszmajsak bartoszmajsak changed the title WIP: Update for Jakarta EE 9 javax to jakarta package move feat: switches to Jakarta EE 9 APIs Apr 28, 2020
@bartoszmajsak bartoszmajsak merged commit fb19bf9 into arquillian:master Apr 28, 2020
@bartoszmajsak
Copy link
Member

Thanks @starksm64 and @manovotn!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants