Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeploymentPackager has no acccess to the Protocol configuration #554

Closed
starksm64 opened this issue Jun 26, 2024 · 0 comments · Fixed by #555
Closed

DeploymentPackager has no acccess to the Protocol configuration #554

starksm64 opened this issue Jun 26, 2024 · 0 comments · Fixed by #555
Assignees
@starksm64

Comments

@starksm64
Copy link
Member

Issue Overview

When a DeploymentPackager is called there is knowledge of the target DeployableContainer
and a ProtocolDefinition which contains the default protocol configuration. This is not provided to the DeploymentPackager via the DeploymentDescription available from the TestDeployment argument to DeploymentPackager#generateDeployment()..

The DeployableContainer is also capable of overriding the protocol and configuration, so that value is what needs to be first looked at, and then fallback to the default ProtocolDefinition if none was specified at the container level. This needs
to be specified on the TestDeployment.

Expected Behaviour

The TestDeployment should have the target protocol information available.

Current Behaviour

This information, while available at the time the DeploymentPackager is called, is not provided via the TestDeployment argument.
@starksm64 starksm64 self-assigned this Jun 26, 2024
starksm64 added a commit to starksm64/arquillian-core that referenced this issue Jun 26, 2024
@starksm64
Enable access to the ProtocolConfiguration info from the TestDeployment.
1997a60 
Fixes arquillian#554

Signed-off-by: Scott M Stark <starksm64@gmail.com>
@starksm64 starksm64 mentioned this issue Jun 26, 2024
Merged
starksm64 added a commit that referenced this issue Jun 27, 2024
@starksm64
Enable access to the ProtocolConfiguration info from the TestDeployme…
5c30bf9 
…nt. (#555)

Fixes #554

Signed-off-by: Scott M Stark <starksm64@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@starksm64 starksm64

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable access to the ProtocolConfiguration info from the TestDeployment. starksm64/arquillian-core
1 participant
@starksm64