chore(ARQ-2172): merged the same runner and rule code to avoid code duplication #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rules enrichment in Arquillian Rule implementation
dipak-pawar
approved these changes
Jan 22, 2018
There was a problem hiding this comment.
@MatousJobanek Nice Improvement. Overall looks good except one comment I have.
| } | ||
| } | ||
|
|
||
| protected void shutdown(TestRunnerAdaptor adaptor) { |
There was a problem hiding this comment.
This can be package-private
bartoszmajsak
approved these changes
Jan 22, 2018
There was a problem hiding this comment.
LGTM, thanks @MatousJobanek. Can you create JIRA ticket so we can link this PR (and also have clean release notes)?
bartoszmajsak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
The code of the
TestRunnerAdaptormanagement is same in both JUnit runner and JUnit class rule. The same can be also applied to the logic that invokes the test method.I've moved the code to separated classes that are used by both implementations. As a benefit:
When I was doing the refactoring, I've noticed that in the rule implementations there was missing enrichment of the other rules used in the test class:
So I added it there.