Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
This PR is a rework of the testng7 support added in #232.
The problems with the original testng7 support are:
Changes proposed in this pull request:
This way: no more code/module duplication, and we are compatible with all versions of testng (if compatibility with testng versions older than 6.0.1 is not required, no need for reflection, just replace ITestNGMethod.getMethod() with ITestNGMethod.getConstructorOrMethod()).
I tested this PR on a project using testng7 and it works (no need for manually adding testng/jcommander as a compile dependency like the workaround proposed in #258).
Fixes #258