feat(junit5): adds support for Suites #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bartoszmajsak @Thihup Please merge this. It works perfectly and solves my issue! |
|
@bartoszmajsak @Thihup Actually half of code in junit5 plugin can be removed (it was copy/pasted from junit4 and never used).. |
Awesome, many thanks. Also for all your great work over the years! (been using suite extension heavily in my previous projects). |
bartoszmajsak
approved these changes
Dec 1, 2020
bartoszmajsak
changed the title
|
@ingwarsw I've just released |
|
@bartoszmajsak Thanks.. I will probably find some spare time in next week.. that one is busy.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
This PR adds support for Suites in junit5 (in same way at it was working in junit4)
So it fixes Arquillian Suite Extension for junit5.
Changes proposed in this pull request:
Add suite finalizer based on auto closable objects on jupiter contexts.
Fixes ingwarsw/arquillian-suite-extension#54