Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: propagates failures with TestNG 7.6.1+ #440

Merged
merged 3 commits into from
Nov 19, 2022

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented Nov 18, 2022

fixes #427
fixes flowlogix/test-arq-suite#49

Short description of what this resolves:

After upgrading to TestNG 7.6.1+ Arquillian no longer works

Changes proposed in this pull request:

Sets status for TestNG tests when tests succeed, fail or skipped.
Previously TestNG status was only set on failure

@lprimak
Copy link
Contributor Author

lprimak commented Nov 18, 2022

@bartoszmajsak Please take a look at this, one, thanks! pretty easy

@bartoszmajsak
Copy link
Member

Thanks @lprimak. First thing in the morning!

Copy link
Member

@bartoszmajsak bartoszmajsak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lprimak

thank-you-toast

@bartoszmajsak bartoszmajsak changed the title fixes failures with TestNG 7.6.1+ fix: propagates failures with TestNG 7.6.1+ Nov 19, 2022
@bartoszmajsak bartoszmajsak merged commit 9028d37 into arquillian:master Nov 19, 2022
@lprimak lprimak deleted the TestNG761Failed branch November 19, 2022 16:44
@tevans78
Copy link

@lprimak @bartoszmajsak Do you have an idea when this fix might make it into a release on maven central? I would guess that might be 1.7.0.Alpha14?

@jhanders34
Copy link
Contributor

@starksm64 Any thoughts on when a release could be created that includes this fix?

@starksm64
Copy link
Member

1.7.0.Alpha14 has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix issue with latest TestNG TestNG fails with versions 7.6 and up
5 participants