Add 9 new exceptional tests #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starksm64
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
The equivalent additions should be made to the https://github.com/arquillian/arquillian-jakarta repo that has the newer jakarta package namespace.
|
Hi @starksm64 , Thanks, I plan to send more tests in that repo in the next few days. |
kifj
added a commit
to kifj/arquillian-core
that referenced
this pull request
Mar 19, 2024
Add new exceptional tests (arquillian#541)
rhusar
reviewed
Mar 26, 2024
| @@ -468,6 +468,16 @@ public String get() { | |||
| }); | |||
| } | |||
|
|
|||
| @Test(expected = IllegalArgumentException.class) | |||
| public void shouldThrowExceptionIfDescriptorIsNull() { | |||
| new PropertiesParser().addProperties(null, System.getProperties()); | |||
There was a problem hiding this comment.
The indentation is completly off in all the changes FYI, please fix this next time. Thanks!
There was a problem hiding this comment.
Ah, even worse, these are tabs, but unfortunately, this project uses spaces...
There was a problem hiding this comment.
Ah, even worse, these are tabs, but unfortunately, this project uses spaces...
Nothing unfortunate about that. It's what Charles Babbage would have wanted... :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Add exceptional tests to existing test files. See issue
Changes proposed in this pull request:
Fixes #542