Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARQ-2235 arquillian-bom should not include Maven artifacts not produced by this project #575

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

rhusar
Copy link
Collaborator

@rhusar rhusar commented Jul 1, 2024

Namely the shrinkwrap project. This is a separate bom produced by separate projects. This otherwise causes dependency ordering headaches for consumers that import this pom into their dependencyManagement section, especially since the currently provided version lags behind upstream releases.

https://issues.redhat.com/browse/ARQ-2235

@rhusar rhusar marked this pull request as draft July 1, 2024 20:34
@rhusar
Copy link
Collaborator Author

rhusar commented Jul 1, 2024

Marked as draft just to have a consensus before we go ahead. This makes the bom be compliant with maven definition - see https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#bill-of-materials-bom-poms

@rhusar rhusar force-pushed the ARQ-2235 branch 2 times, most recently from f330f26 to 486126f Compare July 1, 2024 20:55
rhusar added 3 commits July 1, 2024 22:57
…ed by this project - shrinkwrap projects.

This otherwise causes dependency ordering headaches for consumers that import this pom into their dependencyManagement section,
especially since the currently provided version lags behind upstream releases.
@starksm64
Copy link
Member

Yes, let's go forward with this and I'll do a 1.9.0.Final release

@starksm64 starksm64 marked this pull request as ready for review July 9, 2024 03:02
@starksm64 starksm64 merged commit 9ba4f6f into arquillian:master Jul 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants