Convert test suite to Junit5 #288
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…those tests to a new project
Bumps [org.apache.logging.log4j:log4j-bom](https://github.com/apache/logging-log4j2) from 2.24.2 to 2.24.3. - [Release notes](https://github.com/apache/logging-log4j2/releases) - [Changelog](https://github.com/apache/logging-log4j2/blob/2.x/RELEASE-NOTES.adoc) - [Commits](apache/logging-log4j2@rel/2.24.2...rel/2.24.3) --- updated-dependencies: - dependency-name: org.apache.logging.log4j:log4j-bom dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.apache.httpcomponents.core5:httpcore5](https://github.com/apache/httpcomponents-core) from 5.3.1 to 5.3.2. - [Changelog](https://github.com/apache/httpcomponents-core/blob/rel/v5.3.2/RELEASE_NOTES.txt) - [Commits](apache/httpcomponents-core@rel/v5.3.1...rel/v5.3.2) --- updated-dependencies: - dependency-name: org.apache.httpcomponents.core5:httpcore5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from 5.14.2 to 5.15.2. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v5.14.2...v5.15.2) --- updated-dependencies: - dependency-name: org.mockito:mockito-core dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps org.apache.tomee:arquillian-tomee-remote from 10.0.0-M3 to 10.0.0. --- updated-dependencies: - dependency-name: org.apache.tomee:arquillian-tomee-remote dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
|
Weird commits are showing up, make sure to |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
rhusar
requested changes
Jan 28, 2025
rhusar
reviewed
Jan 28, 2025
| @@ -115,24 +116,26 @@ public static WebArchive createDeployment() { | |||
| .addClass(FailingPhaseListener.class); | |||
| } | |||
|
|
|||
| @Test(expected = ServerWarpExecutionException.class) | |||
| @Test() | |||
There was a problem hiding this comment.
Nitpick: no need for brackets if there are no elements of the @ Test annotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request converts the test suite to JUnit 5 and resolves #220
I fear it is not mergeable, I did something wrong when rebasing. I did a "git pull --rebase upstream main" and then "git push origin --force" (as you suggested some time ago), and after resolving some merge conflicts, github tells me "This branch is 11 commits ahead of, 13 commits behind arquillian/arquillian-extension-warp:main.". So If it s not mergeable, I will create a new pull request.
Main changes:
org.jboss.arquillian.warp.impl.testutils.SeparatedClassloaderRunnerdoes not work with JUnit 5, so I followed the suggestion from Separate ClassLoader per test junit-team/junit5#4203 and added aSeparatedClassloaderExtensionand aLauncherSessionListenerimplementation. Due to conflicts with other tests tampering with the classloader, I extracted all @SeparatedClassPath tests to an extra module "impl_test_separatecl".@RunWith(MockitoJUnitRunner.class)have to be converted to@ExtendWith(MockitoExtension.class), which seems to behave differently when checking stubbings in@BeforeEachmethods (access to stubbed objects seems to be evaluated per test method, while it was before checked per test class), so I added severallenient()calls.