feat: Create findExecutable which searches multiple paths for an executable of a particular executable and returns the found path.
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `isExecutable` no longer always returns false and tries to determine execution status by file extension Co-authored-by: Tom Payne <twpayne@gmail.com>
arran4
force-pushed
the
findExecutable
branch
2 times, most recently
from
60de4b5
to
29e556c
Compare
|
Sorry if you're getting notifications for here. |
arran4
changed the title
findExecutable which searches multiple paths for an executable of a particular name and returns the found path.findExecutable which searches multiple paths for an executable of a particular executable and returns the found path.
arran4
force-pushed
the
findExecutable
branch
3 times, most recently
from
1b46c10
to
4080e6f
Compare
…ecutable of a particular name and returns the found path. As per: twpayne#3141
This reverts commit ed0c798.
Adds a feature requested in discussion twpayne#3161. - This reworks `gitHubLatestTag` to use `gitHubTags` and share the caching between the two functions. - Pagination for both (both size and page number) is not configurable. This will always return the first page of items, where the size of the page is the default specified by GitHub. That is currently thirty items, but is subject to change.
[Homebrew on Linux was formerly referred to as Linuxbrew](https://docs.brew.sh/Homebrew-on-Linux). The two projects got merged.
The discussion in twpayne#3198 suggests some confusion about the order of application. This adds a little more context.
The test for `.chezmoi.targetFile` is excluded from tests because of the difference in path separators. Resolves twpayne#3203
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.6.0 to 3.7.0. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@639cd34...3a91952) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.3 to 3.6.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@c85c95e...f43a0e5) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4.3.0 to 4.4.0. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](goreleaser/goreleaser-action@336e299...3fa32b8) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4.0.1 to 4.1.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@fac708d...93397be) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.2 to 2.21.5. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@0ba4244...00e563e) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…ready been executed
The added documentation serves as the rationale for this documentation
change:
If you use `fish` as your primary shell, you may get warnings from Fish
during the `.txtar` tests:
```
error: can not save history
warning-path: Unable to locate data directory derived from $HOME: '/home/user/.local/share/fish'.
warning-path: The error was 'Operation not supported'.
warning-path: Please set $HOME to a directory where you have write access.
```
These can be avoided with by running tests with `SHELL=bash` or
`SHELL=zsh`:
```console
$ SHELL=bash make test
$ SHELL=zsh make smoketest
$ SHELL=bash go test ./...
```
---
As a note, I tried to make `make test` re-execute when under `fish`, but
it requires some GNU make magic that may not work on all systems:
```Makefile
.PHONY: test
test:
ifeq ($(shell echo $$SHELL | grep -c fish$$),1)
SHELL=$(SHELL) $(MAKE) test
else
${GO} test -ldflags="-X github.com/twpayne/chezmoi/v2/internal/chezmoitest.umaskStr=0o022" ./...
${GO} test -ldflags="-X github.com/twpayne/chezmoi/v2/internal/chezmoitest.umaskStr=0o002" ./...
endif
```
This can be added to this PR or made as a separate PR, if desired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Create
findExecutablewhich searches multiple paths for an executable of a particular name and returns the found path.Resolves: twpayne#3141
I didn't want to squash / force push so much so re-created this. I split out some of the other fixes too.
I think I might need to expose:
os.PathListSeparator&os.PathSeparatoraschezmoi.osPathListSeparatorcan you please indicate if that would be well received?