Bug Fixes #142
Merged
Bug Fixes #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
9prady9
commented
Jun 8, 2017
•
9prady9
commented
- Fixes Array::host, a safe method, can easily cause memory unsafety #135
- Fixes Stream Compaction #124 - Added Array::new_empty that lets you create empty Arrays.
- Fixes locate() does not implement borrow check? #138
- Fixes Host array of eq is incorrect #136 - Updated documentation of comparison operation functions indicating the return Array type.
|
Thank you for adding this! The |
|
@daboross I believe it will break the ABI(not sure how this works in Rust, saying it based on C/C++ experience) but in terms of API, the existing code will still work as long as it was being used with valid types. |
|
@9prady9 Yes, the valid types is all I mean - I don't believe ABI breaking has any real meaning in rust, as the ABI is not stable at all. It would just break if anyone was using it with their own non-HasAfEnum type, but I'm assuming that isn't a concern. |
The Array objects used by Indexer objects were not properly incrementing the reference count. This led to memory corruption and undefined behaviour which is fixed now.
starting commit d558748 rustc-serialize has been replaced in favor of serde. Serde requires rust 1.15.1. Thus, README has been updated reflecting the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.