Skip to content

Chore: bump outdated num and rustc versions #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2021

Conversation

jkelleyrtp
Copy link
Contributor

@jkelleyrtp jkelleyrtp commented May 3, 2021

I ran "cargo-test" and got

test src/algorithm/mod.rs - algorithm::max_ragged (line 1489) ... FAILED

both before and after the version bump, so there aren't any regressions.

max_ragged seems to be failing because "_af_max_ragged" doesn't show up in the macos lib folder for whatever reason.

My IDE also formatted Cargo.toml, but I can try and undo that if autoformatting is unwanted.

Fixes #293

Copy link
Member

@9prady9 9prady9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please separate the formatting changes into a separate commit preferably before the dependency version updates in history.

We prefer keeping formatting changes from any other kind of code changes.

@9prady9
Copy link
Member

9prady9 commented May 3, 2021

max_ragged seems to be failing because "_af_max_ragged" doesn't show up in the macos lib folder for whatever reason.

I haven't had such failures until now, although we had the jobs run in past couple of weeks. So, hard to tell what is causing the this failure on your system. Hopefully, we will know more once the ci jobs run.

@9prady9 9prady9 added this to the 3.8.1 milestone May 3, 2021
@jkelleyrtp
Copy link
Contributor Author

I just got rid of the formatting changes altogether. I use the "Better TOML" plugin for auto toml formatting if you feel like setting up formatting on the .toml files.

Copy link
Member

@9prady9 9prady9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Sure, I can add a toml formatter to avoid different styles for each addition. I will look into it soon.

@9prady9 9prady9 merged commit 6be6c54 into arrayfire:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump num to 0.4.0
2 participants