Fix logic to sequence based indexing in row/col/slice functions #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the following functions were not checking for additional dimensional data beyond the dimension concerned with the particular function. - row - col - slice - rows - cols - slices - set_row - set_col - slice - set_rows - set_cols - set_slices Similar logic was missing in one particular matching pattern of view macro which is also fixed in this change. Few additional unit tests are added in macro and index module checking for the pitfalls this change addresses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the following functions were not checking for additional
dimensional data beyond the dimension concerned with the particular
function.
Similar logic was missing in one particular matching pattern of view
macro which is also fixed in this change.
Few additional unit tests are added in macro and index module checking
for the pitfalls this change addresses
Fixes #295