-
Notifications
You must be signed in to change notification settings - Fork 59
Error in build script when no backends are found #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a19fe88
to
8fb4b4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the delay. Couple of minor comments. Can you also please look into the Clippy annotations from the build.rs
file. Would be great if you address the other two files also. Thank you!
I have fixed the clippy warnings in separate commit. If you can look into ci job change and let me know if that is even possible re-use. If it isn't, we can go ahead with this merge. Thank you |
This would result in a linker error anyway. By th rowing the error earlier, we make it easier for the user to debug their arrayfire installation.
The clippy job now needs arrayfire to because the build script checks for a valid arrayfire installation.
8fb4b4f
to
15f63ca
Compare
Thanks! I rebased this PR on top of the latest changes from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thank you once again @phil-opp
Fixes #308
Also:
Cargo only shows the stderr/stdout of build scripts if they fail. So the new warnings do not clutter the output of successful builds.
Example output when a folder is inaccessible: