Support implicit promoting with f16 #321
Conversation
|
I think the clippy errors are inherited from the current HEAD. |
9prady9
force-pushed
the
bp-fix-f16-implicitpromoting
branch
from
0c1e9e9 to
d1b9d67
Compare
umar456
force-pushed
the
bp-fix-f16-implicitpromoting
branch
from
d1b9d67 to
fb98756
Compare
umar456
force-pushed
the
bp-fix-f16-implicitpromoting
branch
from
eab810f to
552a84a
Compare
|
@9prady9 I think this is good to go. I made additional changes for f16 for other functions but I was having a problem with the negate function. I think the problem is that the num package does support half::f16 but I am not sure. |
|
@umar456 thanks umar, will take a look at it soon. |
9prady9
force-pushed
the
bp-fix-f16-implicitpromoting
branch
from
552a84a to
93b1036
Compare
I took care of those, thanks for letting me know. |
thank you. Documentation is not clear on that one, I will check that once more. |
9prady9
force-pushed
the
bp-fix-f16-implicitpromoting
branch
from
93b1036 to
0639258
Compare
|
Could we also update the half 1.5.0 to half 2.2.0 in arrayfire-rust? to get new features |
- Create a ImplicitPromote<f16> trait and implement it for other types - Implement ImplicitPromote<T> traits for f16
9prady9
force-pushed
the
bp-fix-f16-implicitpromoting
branch
from
0639258 to
f0c63ac
Compare
There was a problem hiding this comment.
Sorry about the extended delay on this. Thanks for this contribution @Benjamin-Philip and @umar456 for pitching in.
Closes #320