Skip to content

Set correct number of dimensions for convolve2_nn and convolve2_gradient_nn #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2022
Merged

Set correct number of dimensions for convolve2_nn and convolve2_gradient_nn #324

merged 2 commits into from
Jun 23, 2022

Conversation

c0dearm
Copy link
Contributor

@c0dearm c0dearm commented Jun 23, 2022

Fixes issue #323

@c0dearm c0dearm mentioned this pull request Jun 23, 2022
Closed
2 tasks
@9prady9
Copy link
Member

9prady9 commented Jun 23, 2022

Sorry about the incorrect fix and thanks for looking into it. Can you please fix the clippy errors.

@c0dearm
Copy link
Contributor Author

c0dearm commented Jun 23, 2022 •
edited
Loading

@9prady9 those are unrelated to my changes, but I can invest some time fixing them if you wish

@9prady9
Copy link
Member

9prady9 commented Jun 23, 2022

Ah i see, opencl-interop package. If you could fix them quickly, that would be great. I can't get to it right away.

@c0dearm
Copy link
Contributor Author

c0dearm commented Jun 23, 2022

@9prady9 done!

@c0dearm
Copy link
Contributor Author

c0dearm commented Jun 23, 2022

I can't merge it because of permissions, please do it yourself @9prady9

@9prady9 9prady9 merged commit 5209591 into arrayfire:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9prady9 9prady9 9prady9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c0dearm @9prady9