This repository has been archived by the owner on Mar 30, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Add docs for kotlin:ank:playground #53
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a8399ed
Add playgrounds
nomisRev f3c3947
Merge branch 'master' into sv-add-docs-playground
nomisRev 6864fa4
Merge branch 'master' into sv-add-docs-playground
rachelcarmena 6d872e1
Merge branch 'master' into sv-add-docs-playground
nomisRev 17095e2
Merge branch 'master' into sv-add-docs-playground
rachelcarmena File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a reminder about the need for having all the sources you need in the snippet otherwise it'll fail. Also clarify that if you need to showcase compile time generated syntax you'll need to copy those generated elements on the snippet, given Playgrounds can only depend on the sources in the snippet, and the playgrounds server doesn't run kapt either.
About the different behavior between Ank and playgrounds when it comes to classpath dependencies: Playgrounds can also work incrementally so you don't need to redeclare everything on every single snippet, like Ank does. You can do it with an "incremental" flag but last time I tried random stuff failed, so I'm not completely sure whether that works fine.