Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Update internal atomic wrapper #104

Merged
merged 13 commits into from
May 8, 2020
Merged

Update internal atomic wrapper #104

merged 13 commits into from
May 8, 2020

Conversation

aballano
Copy link
Member

@aballano aballano commented May 7, 2020

Add missing getAndUpdate fun
Add missing return types
Add couple of inlines to high-order functions
Put declarations on new line

Add missing return types
Add couple of inlines to high-order functions
Put declarations on new line
@aballano
Copy link
Member Author

aballano commented May 7, 2020

@rachelcarmena as soon as this gets green I'd like to push a change for a more restrictive gradle config in which we only put the atomicfu deps on the module using it, if it makes sense 😅

@rachelcarmena
Copy link
Member

@rachelcarmena as soon as this gets green I'd like to push a change for a more restrictive gradle config in which we only put the atomicfu deps on the module using it, if it makes sense sweat_smile

Of course! Thanks @aballano 🙌 Right, it's being used for the whole arrow-core and arrow-fx so far. Good idea!! 👍

@aballano
Copy link
Member Author

aballano commented May 8, 2020

@rachelcarmena as soon as this gets green I'd like to push a change for a more restrictive gradle config in which we only put the atomicfu deps on the module using it, if it makes sense 😅

NVM it seems some atomic is used in core-data so we cannot restrict it too much for now

@rachelcarmena
Copy link
Member

@rachelcarmena as soon as this gets green I'd like to push a change for a more restrictive gradle config in which we only put the atomicfu deps on the module using it, if it makes sense sweat_smile

NVM it seems some atomic is used in core-data so we cannot restrict it too much for now

Or maybe it could be added just for both 🙌

@aballano aballano merged commit c1b9c19 into master May 8, 2020
@aballano aballano deleted the ab/update-atomic branch May 8, 2020 13:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants