Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Maintain Traverse and TraverseFilter documents #122

Merged
merged 3 commits into from
May 22, 2020

Conversation

hadilq
Copy link
Contributor

@hadilq hadilq commented May 21, 2020

  • Create typeclasses/traverse/README.md
  • Complete typeclasses/traversefilter/README.md
  • Fix link in typeclasses/functor/README.md
  • Modify Traverse.kt and TraverseFilter.kt comments


## Traverse


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional empty lines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked and there is exactly 4 lines in Functor, Foldable, and Monad, etc. So I concluded it's okey to have them in this doc too. lmkwdyt.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird. Okay, let's roll with it.



The `Traverse` typeclass is allowing to commute types from `F<G<A>>` to `G<F<A>>` over sequential execution of code.
Traversal over a structure with an effect.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main use of this is traversal over...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! See 4e5f8d6

Copy link
Member

@pakoito pakoito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it :D A couple of fixes and ready to go!

@pakoito pakoito merged commit 1462bb4 into arrow-kt:master May 22, 2020
@hadilq hadilq deleted the traverse-doc branch May 22, 2020 13:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants