-
Notifications
You must be signed in to change notification settings - Fork 30
Add nullable fns to replace option fns #191
Add nullable fns to replace option fns #191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍 Thanks @tapegram
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @tapegram! Very excited to see a new contributor 🎉
One small comment: we use Ank to verify documentation at build time, and we also use it for post-processing with dokka to turn code snippets in to Kotlin playground snippets :)
We should update the snippets in this PR to also use kotlin:ank:playground
.
80431d6
to
c4f1fda
Compare
c4f1fda
to
231b033
Compare
Hey @tapegram, For a Kotlin playground snippet to be runnable it needs to contain a I created a PR to add docs for |
Thanks for the contributions @tapegram ❤️ |
#120
Update Either and Ior to have nullable alternatives to their option creating methods, other datatypes to follow.