Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Add nullable fns to replace option fns #191

Merged

Conversation

tapegram
Copy link
Contributor

#120

Update Either and Ior to have nullable alternatives to their option creating methods, other datatypes to follow.

@tapegram tapegram marked this pull request as ready for review July 23, 2020 02:59
Copy link
Member

@aballano aballano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 Thanks @tapegram

@aballano aballano linked an issue Jul 23, 2020 that may be closed by this pull request
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @tapegram! Very excited to see a new contributor 🎉

One small comment: we use Ank to verify documentation at build time, and we also use it for post-processing with dokka to turn code snippets in to Kotlin playground snippets :)
We should update the snippets in this PR to also use kotlin:ank:playground.

arrow-core-data/src/main/kotlin/arrow/core/Either.kt Outdated Show resolved Hide resolved
@tapegram tapegram force-pushed the add_nullable_fns_to_replace_option_fns branch from 80431d6 to c4f1fda Compare July 23, 2020 17:50
@tapegram tapegram force-pushed the add_nullable_fns_to_replace_option_fns branch from c4f1fda to 231b033 Compare July 23, 2020 17:52
@nomisRev
Copy link
Member

Hey @tapegram,
Sorry, I didn't specify more clearly yesterday and I noticed it's not available in the Ank README.

For a Kotlin playground snippet to be runnable it needs to contain a main function.
It's a bit annoying since it convolutes the snippet, but it's currently the only way we have to make these snippets runnable on the website.

I created a PR to add docs for playground and I added a ticket for Ank to verify the main block in playground 👍

arrow-kt/arrow-ank#53, arrow-kt/arrow-ank#54.

@nomisRev nomisRev merged commit 358ca2d into arrow-kt:master Jul 27, 2020
@nomisRev
Copy link
Member

Thanks for the contributions @tapegram ❤️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

orNull API to cover the deprecated Option API.
3 participants