Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Replacing the rest of the Option<T> in ListK with T? #216

Merged
merged 3 commits into from
Aug 18, 2020
Merged

Replacing the rest of the Option<T> in ListK with T? #216

merged 3 commits into from
Aug 18, 2020

Conversation

tapegram
Copy link
Contributor

@tapegram tapegram commented Aug 18, 2020 •
edited
Loading

Should be the last bit of ListK nullable alternatives to Option

nomisRev
nomisRev approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tapegram!!

aballano
aballano approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@aballano aballano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@aballano aballano merged commit feaa5d6 into arrow-kt:master Aug 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nomisRev nomisRev nomisRev approved these changes

@aballano aballano aballano approved these changes

@1Jajen1 1Jajen1 Awaiting requested review from 1Jajen1

@rachelcarmena rachelcarmena Awaiting requested review from rachelcarmena

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tapegram @aballano @nomisRev