-
Notifications
You must be signed in to change notification settings - Fork 30
Updating MapK
to have Option
alternatives
#222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks @tapegram.
Small nit, I think we can remove some allocations :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tapegram! This will safe us some allocations in the implementations 🎉
EDIT: Seems you still need to run ktlintFormat
, I tried to do it for you but couldn't push to this branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat 👌
10f21ac
to
a781ed2
Compare
@@ -42,7 +42,6 @@ import arrow.typeclasses.Traverse | |||
import arrow.typeclasses.Zip | |||
import arrow.typeclasses.Unalign | |||
import arrow.typeclasses.Unzip | |||
import arrow.typeclasses.hashWithSalt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this got picked up as unused by ktlintformat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @tapegram, thank you!
Update a few functions that use Option to use nullables instead.
Deprecate two functions and provide alternatives.