This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Replace ConcurrentLaws' latch with unsafe promise #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame approach as the cancellable one is flakyly failing for some mtl instances arrow-kt/arrow-incubator#75
aballano
force-pushed
the
ab/align-concurrent-cancellable
branch
from
b776977
to
4acc243
Compare
|
Nevermind, the laws are fine as they are, sorry for the noise. |
aballano
force-pushed
the
ab/align-concurrent-cancellable
branch
from
ef72452
to
d86f7f8
Compare
|
Reopening as @nomisRev found a nicer way by replacing CountDownLatch by UnsafePromise. |
aballano
changed the title
|
kiss fingertips |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might improve the tests in arrow-kt/arrow-incubator#85