Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

arrow-fx-android: move Gradle configuration to the module #162

Merged
merged 1 commit into from
May 22, 2020

Conversation

rachelcarmena
Copy link
Member

@rachelcarmena rachelcarmena commented May 22, 2020

PR on ab/lifecycle-integration branch-

Fix one of the TODO items from #158:

  • Figure out if it's possible to move the root build.gradle's added config for android to the specific module

I followed this guide: https://developer.android.com/studio/build#build-files

@github-actions
Copy link

Hood benchmark comparison:
✔️ Concurrentqueue (Threshold: 22.449104307498743)

Benchmark Value
master-branch 255.3244352720936
pull-request 269.5649127440558

@aballano
Copy link
Member

Thanks @rachelcarmena!!

@aballano aballano merged commit 7871a3e into ab/lifecycle-integration May 22, 2020
@aballano aballano deleted the fix/ab/lifecycle-integration branch May 22, 2020 14:11
nomisRev added a commit that referenced this pull request Jun 8, 2020
* initial commit

* Nits

* Nits

* Initial version of deferUntilActive (not fully working)

* Nits

* convert android integration into an android module

* build.gradle cleanup

* nits

* Remove deferUntilActive function for now

* nit

* arrow-fx-android: move Gradle configuration to the module (#162)

* Bump android gradle plugin

* Add publish config

* add isReleaseBuild gradle function

* nit

* Tuning configuration (#170)

Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com>
Co-authored-by: Rachel M. Carmena <rachelcarmena@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants