-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
… into sv-arrow-fx-coroutines
This reverts commit 32badbd.
I know this is a hard to answer question but, how many iterations are okay to ensure code integrity? Could 100 iterations be too low to test an acceptable amount of edge cases? |
@JorgeCastilloPrz Kotest checks that you have enough iterations to cover all I just double checked for KotlinTest, and it doesn't have the same assurance but we need to refactor to Kotest asap since we're a version behind now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if this is compatible with arrow-kt/arrow-core#105 somehow?
@aballano it's definitely combine-able with arrow-kt/arrow-core#105, but I feel like we should come up with a strategy that also incorporates upgrading to kotest. |
Reduced the stress of our test suite by 10x by reducing the iterations to 100 instead of 1000.
This has shaved off ~ 7minutes on my local machine, while still covering all
edgeCases
.There are two implementations here based on
Kotest
in Arrow Fx Coroutines, andKotlinTest
in the rest.We should push this change down to
Arrow Core Test
, so we can also configureiterations
for law testing.Proposed follow up work
Ideally, we'd decouple property testing from
Kotest
so:This allows for more flexibility as you could plug it into both
KotlinTest
&Kotest
and that simply becomes a integration instead of hard-coupled as it is today.This also decouples the property testing from the law definition, and would allow us to easily control test strategy by the caller.