This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Fix issue SuspendConnection #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulraja
approved these changes
Jun 22, 2020
rachelcarmena
approved these changes
Jun 22, 2020
There was a problem hiding this comment.
Thanks @nomisRev !! I'll change arrow repository and then I'll update the build step with the general script. Congrats!!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SuspendConnection now uses
Platform.unsafeRunSyncinternally to cancel a token when the connection is already cancelled.Instead it should use
startCoroutinethat runs on an empty context, which allows for the cancel token to fork and exit the existing context.