This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Use of KOTEST_VERSION property #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to help to the progressive use of Kotest.
aballano
approved these changes
Jun 26, 2020
rachelcarmena
commented
Jun 29, 2020
| val last = max(a, b) | ||
| first..last | ||
| } | ||
| fun Arb.Companion.intRange(min: Int = Int.MIN_VALUE, max: Int = Int.MAX_VALUE): Arb<IntRange> = |
There was a problem hiding this comment.
@nomisRev , thank you so much for making it work for Kotest 4.1.0 🎉 Just a small question, could this change impact on current tests? I mean, the max value changed from 1000 to 2147483647. Thanks in advance!!
There was a problem hiding this comment.
And the min value also changes (from 0 to -2147483648).
There was a problem hiding this comment.
Hey @rachelcarmena,
The reason for this change was to make the generator more accurate.
The only current usage from this Arb explicitly defines min & max, so it doesn't impact the current suite.
There was a problem hiding this comment.
Great, thank you so much Simon!! 🙌
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to help to the progressive use of Kotest.
Note: it corresponds to
4.1.0instead of4.0.6. Let's see if it works...