Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Complete test suite to check interception #207

Merged
merged 10 commits into from
Jul 1, 2020

Conversation

nomisRev
Copy link
Member

Follow up PR #203, which exposed returning to incorrect contexts in timeOutOrNull.

This PR adds these tests for all operators and optimizes them further from suspendCoroutine to suspendCoroutineUninterceptedOrReturn.

All other operators in this PR were working correctly but add tests to prevent regression.
For example, the interception in Fiber#join comes from suspendCoroutine in the cancellable builder.

Copy link
Member

@aballano aballano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good 👍

@nomisRev nomisRev merged commit 013e139 into master Jul 1, 2020
@nomisRev nomisRev deleted the sv-add-tests-for-returning-ctx branch July 1, 2020 10:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants