This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Revert IO<E, A> back to IO<A> #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aballano
commented
Jul 2, 2020
| @@ -1065,7 +1187,7 @@ fun <E, A, B, E2 : E> IOOf<E, A>.flatMap(f: (A) -> IOOf<E2, B>): IO<E2, B> = | |||
| * } | |||
| * ``` | |||
| */ | |||
| fun <E, A> IO<E, EitherOf<E, A>>.flattenEither(): IO<E, A> = | |||
| fun <E : Throwable, A> IO<EitherOf<E, A>>.flattenEither(): IO<A> = | |||
There was a problem hiding this comment.
👀 @nomisRev @JorgeCastilloPrz Although not as useful as before, I left this functions here but restraining E to throwable, so they can still be used in certain situations
nomisRev
suggested changes
Jul 2, 2020
| val disposable = fix().unsafeRunAsyncCancellable { either -> | ||
| either.fold(cont::resumeWithException) { cont.resume(it) } | ||
| val disposable = fix().unsafeRunAsyncCancellable { result -> | ||
| result.fold<Unit>(cont::resumeWithException, cont::resume) |
There was a problem hiding this comment.
If you specify Unit for fold does it allow you to use cont::resume and otherwise it doesn't? :O
There was a problem hiding this comment.
No idea, just removed the explicit type to see if it compiles
There was a problem hiding this comment.
And it doesn't, need to add it explicitely 😂
There was a problem hiding this comment.
Cool. Didn't know you could fix bypassing <Unit> to fold.
I've always made anonymous lamdas
arrow-fx-rx2/src/main/kotlin/arrow/fx/rx2/FlowableKConnection.kt
Outdated
Show resolved
Hide resolved
arrow-fx-rx2/src/main/kotlin/arrow/fx/rx2/ObservableKConnection.kt
Outdated
Show resolved
Hide resolved
aballano
commented
Jul 3, 2020
| IO.Bind(IO.ContextSwitch(applyRelease(ExitCase2.Exception(e)), IO.ContextSwitch.makeUncancellable, disableUncancellableAndPop), | ||
| ReleaseRecoverException(e)) | ||
| override fun recover(e: Throwable): IO<B> = | ||
| IO.Bind( |
There was a problem hiding this comment.
@nomisRev I brought back this as well FYI
nomisRev
approved these changes
Jul 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0d7c9c2.
Fixes #175