This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Enviroment #214
Merged
Enviroment #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joramnv
reviewed
Jul 2, 2020
arrow-fx-coroutines/src/main/kotlin/arrow/fx/coroutines/Enviroment.kt
Outdated
Show resolved
Hide resolved
| * | ||
| * This contract could be elaborated on Android to provide automatic cancellation on Android LifecycleOwner. | ||
| */ | ||
| interface Environment { |
There was a problem hiding this comment.
I really like the implementation. Can't wait to use it! 😃
arrow-fx-coroutines/src/main/kotlin/arrow/fx/coroutines/Enviroment.kt
Outdated
Show resolved
Hide resolved
|
Thanks @joramnv for the code review! 🙌 |
JorgeCastilloPrz
approved these changes
Jul 3, 2020
Co-authored-by: Jorge Castillo <jorge.castillo.prz@gmail.com>
pakoito
reviewed
Jul 7, 2020
|
|
||
| /** | ||
| * Execution strategies that will immediately return and perform the program's work without blocking the current thread. | ||
| * This operation runs uncancellable. |
There was a problem hiding this comment.
It may be worth adding a note about how exceptions are handled in this particular case.
pakoito
reviewed
Jul 7, 2020
aballano
approved these changes
Jul 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes an [Enviroment] interface, that can be used instead of the bare bones runners which don't provide elegant syntax.
The Enviroment type offers the same runners as
UnsafeRuncurrently offers forF.It however also incorporates
CoroutineContextandasyncErrorHandler.asyncErrorHandlerwould currently be called only forcancellableFwhen it's returnedCancelTokenthrows an exception. ref.CoroutineContextdefines an initial ctx forunsafeRunSyncso we don't need anEventLoop. This however means that by defaultunsafeRunSynccalled frommainruns onForkJoinPool.Alternative would be to start on
EmptyCoroutineContextbut then we'd return the user toForkJoinPoolafter the firstsleepor other parallel op.