This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Small Queue improvements #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,7 +32,7 @@ internal interface Publish<A> { | |||
| * Evaluates to `false` if element was not published. | |||
| * Evaluates to `true` if element was published successfully. | |||
| */ | |||
| suspend fun tryPublish(a: A): Boolean | |||
| fun tryPublish(a: A): Boolean | |||
There was a problem hiding this comment.
Because the underlying implementation was still relying on suspension, which has now been rewritten to work without suspension.
EDIT: it was sharing code with suspend fun publish.
nomisRev
commented
Jul 29, 2020
| @@ -39,7 +39,7 @@ interface Enqueue<A> { | |||
| * | |||
| * @param a `A` to enqueue | |||
| */ | |||
| suspend fun offer1(a: A): Boolean | |||
| fun tryOffer1(a: A): Boolean | |||
There was a problem hiding this comment.
@JorgeCastilloPrz breaking change in Arrow Fx Coroutine Stream's Queue.
nomisRev
commented
Jul 29, 2020
| /** Creates a FILO queue with the specified size bound. */ | ||
| suspend fun <A> boundedLife(maxSize: Int): Queue<A> = |
There was a problem hiding this comment.
@JorgeCastilloPrz Second breaking change
danimontoya
approved these changes
Jul 29, 2020
| @@ -39,7 +39,7 @@ interface Enqueue<A> { | |||
| * | |||
| * @param a `A` to enqueue | |||
| */ | |||
| suspend fun offer1(a: A): Boolean | |||
| fun tryOffer1(a: A): Boolean | |||
There was a problem hiding this comment.
that was fast!! thank youu!! 🎉
aballano
approved these changes
Jul 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of small improvements to
Queue.suspendfromtryOfferand signal usingBooleaninstead to interopt from non-suspend codePubSubandQueue.