This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
Queue new API + docs #30
Merged
Merged
Changes from 32 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
dbcdf4a
Merge new Queue internal impl with Queue
nomisRev af71858
Add some additional tests for new behavior
nomisRev 4f83932
Add more tests
nomisRev 2d2f695
Merge remote-tracking branch 'origin/master' into sv-queue-part-2
nomisRev d32ec2d
Add Concurrent syntax for Queue
nomisRev 0e489f8
Fix compileJmhKotlin
nomisRev e98dc30
Merge branch 'master' into sv-queue-part-2
nomisRev e34098b
Fix documentation
nomisRev ecd4eec
Merge branch 'master' into sv-queue-part-2
rachelcarmena f3ea469
Merge branch 'master' into sv-queue-part-2
nomisRev 73efd48
Merge remote-tracking branch 'origin/master' into sv-queue-part-2
nomisRev fa0f32a
Update Queue tests
nomisRev 34ef6f3
Merge branch 'master' into sv-queue-part-2
nomisRev 701ea3f
Add takeAll & peekAll
nomisRev b777802
Add tryOfferAll
nomisRev c48514d
Add offerAll
nomisRev a53876d
First round of PR review
nomisRev 76e6fc4
Merge remote-tracking branch 'origin/master' into sv-queue-part-2
nomisRev d9b29ba
Merge branch 'master' into sv-queue-part-2
nomisRev 2b903c2
Apply suggestions from doc lang review
nomisRev 77abcc1
Fix offerAll cancelation
nomisRev 75861ec
Merge branch 'master' into sv-queue-part-2
aballano 98f339f
Add docs to Dequeue
nomisRev ee3faf7
Merge branch 'sv-queue-part-2' of github.com:arrow-kt/arrow-fx into s…
nomisRev 7b2df23
Remove `shutdown` from `Queue` API
nomisRev 58d9eef
Remove LinkedMap and use LinkedHashMap instead
nomisRev a8ab3e2
Refactor API to be Iterable instead of Collection
nomisRev cdd4a7f
Add tests to check all strategies
nomisRev 40657f3
Add examples queue strategies
nomisRev 99217bc
Fix unresolved A Dequeue docs
nomisRev 61e7155
Fix Dequeue docs some more
nomisRev a200d41
Fix Sliding KDoc example
nomisRev aa69fbe
Merge branch 'master' into sv-queue-part-2
aballano 2aa7ddf
Merge branch 'master' into sv-queue-part-2
danimontoya ae81131
Merge branch 'master' into sv-queue-part-2
aballano 9e6c6c7
Apply suggestions from doc review
nomisRev ff076bd
Code review, remove Shutdown references
nomisRev ee1e753
Merge branch 'sv-queue-part-2' of github.com:arrow-kt/arrow-fx into s…
nomisRev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this explicit
equalUnderTheLaw
? Cannot we test like before using the one above?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's for a proper assertion message. The one implement through
IO.toString
is not very meaningful.#30 (comment)