This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Fix several tests relying on no-op assertion #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ures Update Mvar read and take docs to explicitly detail if the value is removed or not
nomisRev
reviewed
Feb 25, 2020
nomisRev
reviewed
Feb 25, 2020
aballano
commented
Feb 25, 2020
nomisRev
suggested changes
Feb 25, 2020
… ab/fix-mvar-tests
… ab/fix-mvar-tests
aballano
commented
Feb 26, 2020
| @@ -18,13 +18,13 @@ fun throwableEq() = Eq { a: Throwable, b -> | |||
| data class Law(val name: String, val test: suspend TestContext.() -> Unit) | |||
|
|
|||
| fun <A> A.equalUnderTheLaw(b: A, eq: Eq<A>): Boolean = | |||
| eq.run { eqv(b) } | |||
| shouldBeEq(b, eq).let { true } | |||
|
Current test status:
|
…nd fix some IO comparisons
Cleanup test by generating EQ based on EqK
Rework Resource to have different states depending on constructor, similar as IO Add fold function to do tailrec recursion over Bind chains Make use function depend on fold Rework tailRecM function to operate over the different states, fixing the stack overflow issue
danimontoya
reviewed
Mar 2, 2020
… ab/fix-mvar-tests
… ab/fix-mvar-tests
danimontoya
approved these changes
Mar 4, 2020
# Conflicts: # arrow-fx/src/main/kotlin/arrow/fx/internal/CancellableMVar.kt # arrow-fx/src/test/kotlin/arrow/fx/KindConnectionTests.kt
nomisRev
approved these changes
Mar 5, 2020
| * A Map which tracks the insertion order of entries, so that entries may be | ||
| * traversed in the order they were inserted. | ||
| */ | ||
| internal class LinkedMap<K, V>( |
There was a problem hiding this comment.
Can we use LinkedHashMap from kotlin.collections instead?
There was a problem hiding this comment.
Nope AFAIK :D Actually the current MVar has already that kind of list
arrow-fx/src/main/kotlin/arrow/fx/internal/UncancellableMVar.kt
Outdated
Show resolved
Hide resolved
arrow-fx/src/main/kotlin/arrow/fx/internal/UncancellableMVar.kt
Outdated
Show resolved
Hide resolved
| override fun <A> genK(gen: Gen<A>): Gen<Kind<ResourcePartialOf<ForIO, Throwable>, A>> = | ||
| Gen.oneOf( | ||
| gen.map { just(it, IO.bracket()) }, | ||
| IO.genK().genK(gen).map { it.liftF(IO.bracket()) } |
There was a problem hiding this comment.
Here you can see how the Gen is build for Resource in Cats effect.
It build Allocate from Gen<Kind<F, A>> and Gen<Kind<F, Unit>>, it builds FlatMap from the allocate Gen and another for Suspend.
The idea here is that if your Kind<F, A> for example IO<A> is a strong generator that also generates IO at depths etc so it can cover all its cases.
| @@ -300,3 +300,7 @@ internal fun <A> asyncContinuation(ctx: CoroutineContext, cc: (Either<Throwable, | |||
| */ | |||
| internal fun <A> IOForkedStart(fa: IOOf<A>, ctx: CoroutineContext): IO<A> = | |||
| IO.Bind(IO.ContinueOn(IO.unit, ctx)) { fa.fix() } | |||
|
|
|||
| @Suppress("UNCHECKED_CAST") | |||
| internal fun <A, B> A.unsafeCast(): B = | |||
There was a problem hiding this comment.
nomisRev
reviewed
Mar 5, 2020
| onOutput: (A) -> Kind<F, B>, | ||
| onRelease: (Kind<F, Unit>) -> Kind<F, Unit> | ||
| ): Kind<F, B> { | ||
| // Interpreter that knows how to evaluate a Resource data structure | ||
| // Maintains its own stack for dealing with Bind chains | ||
| tailrec fun loop(current: Resource<F, E, Any>, stack: List<(Any) -> Resource<F, E, Any>>): Kind<F, Any?> = | ||
| tailrec fun loop(current: Resource<F, E, A>, stack: List<(A) -> Resource<F, E, A>>): Kind<F, B> = |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING: Make
equalUnderTheLawthrow an exception when the evaluation is false. With this we want to make sure that all tests are verifying something, otherwise non-boolean tests (all tests not usingforAll/Few) can naively callequalUnderTheLawat the end but fail to remember to verify the condition as the name doesn't suggest it. This therefore caused different kind of failures:equalUnderTheLaw, either with a boolean condition or withshouldBe-> Simply fixed them by using a more appropriate assertionAll changes are explained below:
equalUnderTheLawto rely onshouldBeEqand throw on failureshouldBeEqimpl as it tries to print the values after the assertion and it causes a stack overflow due to the chained stack.