This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Removed (almost) all Try examples in documentation/comment blocks #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aballano
approved these changes
Feb 28, 2020
aballano
approved these changes
Mar 3, 2020
| val (two) = Try { one + one } | ||
| Either.fx<Throwable, Int> { | ||
| val (one) = Either.right(1) | ||
| val (two) = Either.right(one+one) |
There was a problem hiding this comment.
nit:
Suggested change
| val (two) = Either.right(one+one) | |
| val (two) = Either.right(one + one) |
| FlowableK.monad().fx.monad { | ||
| (1..50000).fold(just(0)) { acc: Kind<ForFlowableK, Int>, x: Int -> | ||
| just(acc.bind() + 1) | ||
| }.bind() | ||
| }.fix().flowable.blockingFirst() | ||
| } | ||
| }.attempt() |
There was a problem hiding this comment.
Suggested change
| }.attempt() | |
| }.attempt()..unsafeRunSync() |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR can be seen here.
What version are you currently using? 0.10
What would you like to see?
The documentation includes Try examples. Since Try is deprecated, these examples should be removed (or transitioned to Either examples) to prevent confusion.