Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Update Arrow "cancel" wording for consistency #82

Merged
merged 6 commits into from
Mar 5, 2020
Merged

Conversation

aballano
Copy link
Member

@aballano aballano commented Mar 4, 2020

Brings arrow-kt/arrow#2050 to 0.10.5 with deprecation over functions and types

@aballano aballano added this to the 0.10.x milestone Mar 4, 2020
@danimontoya danimontoya merged commit 043c0ec into master Mar 5, 2020
@danimontoya danimontoya deleted the wording-rework branch March 5, 2020 10:16
@rachelcarmena
Copy link
Member

Hi! Sorry for not reviewing this PR before... this change is already done for 0.11.0-SNAPSHOT by @nomisRev . I don't know if we want to wait for that version to do this change...

@rachelcarmena
Copy link
Member

Arrow Incubator and Arrow Optics were also changed for that version because this improvement impacts to them.

BTW, the issue wasn't created because of having double quotes in the PR title (it's already fixed). It will be created in a few minutes.

@aballano
Copy link
Member Author

aballano commented Mar 5, 2020

Hi! Sorry for not reviewing this PR before... this change is already done for 0.11.0-SNAPSHOT by @nomisRev . I don't know if we want to wait for that version to do this change...

Not exactly, I merged the change into the release branch due to a mistake, the process should have been first this PR with the deprecations and then remove the deprecations in 0.11

Arrow Incubator and Arrow Optics were also changed for that version because this improvement impacts to them.

We will take a look there as well, thank you!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants