Add fiber integration + docs #86
Conversation
nomisRev
requested review from
aballano,
JorgeCastilloPrz,
danimontoya and
pakoito
| val promise = UnsafePromise<A>() | ||
|
|
||
| if (newContext.isActive) { | ||
| val disposable = IO.unit.continueOn(newContext).flatMap { fix() } |
There was a problem hiding this comment.
is there a difference of doing newContext.shift().followedBy(fix()) instead? Mainly wondering because I've seen both codes in different places but didn't really grasp the diff if any 😬
There was a problem hiding this comment.
No difference, newContext.shift() <==> IO.unit.continueOn(newContext).
arrow-fx-kotlinx-coroutines/src/main/kotlin/arrow/integrations/kotlinx/extensions.kt
Outdated
Show resolved
Hide resolved
...x-kotlinx-coroutines/src/test/kotlin/arrow/integrations/kotlinx/CoroutinesIntegrationTest.kt
Show resolved
Hide resolved
...x-kotlinx-coroutines/src/test/kotlin/arrow/integrations/kotlinx/CoroutinesIntegrationTest.kt
Outdated
Show resolved
Hide resolved
| */ | ||
| suspend fun <A> IOOf<A>.suspendCancellable(): A = | ||
| suspendCancellableCoroutine { cont -> | ||
| if (cont.isActive) { |
There was a problem hiding this comment.
Nice, we should not even run our thing if the enclosing scope is already cancelled 👍
| fun <A> IOOf<A>.unsafeRunScoped( | ||
| scope: CoroutineScope, | ||
| f: (Either<Throwable, A>) -> Unit | ||
| cb: (Either<Throwable, A>) -> Unit |
There was a problem hiding this comment.
Are these part of the work for homogenizing names across the library?
There was a problem hiding this comment.
Not really, but that was the reason I renamed here.
So far all callbacks in Arrow Fx have the shape (Either<Throwable, A>) -> Unit with param name cb.
…row-fx into sv-kotlinx-fiber-integration
Solves #84
This PR adds a combinator to launch a
Fiberand attach it's cancelation system to KotlinX's CoroutineScope.This allows for automatic cancelation of fibers with structured concurrency, useful for scoping a fiber to the render scope on Android for example.
Additionally I noticed we don't check
isActive, I'd like to add some tests for this before I promote the PR but it's ready to review already.TODO: add tests for
isActive.