Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing test and fix merge review changes #2016

Merged
merged 4 commits into from
Feb 3, 2020
Merged

Add missing test and fix merge review changes #2016

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d201339
Add missing test and fix merge review changes
nomisRev Jan 31, 2020
3fed1be
Merge remote-tracking branch 'origin/release/0.11.0' into sv-merge-ra…
nomisRev Jan 31, 2020
ea32b0d
Merge remote-tracking branch 'origin/release/0.11.0' into sv-merge-ra…
nomisRev Feb 3, 2020
a9f2c91
Merge branch 'release/0.11.0' into sv-merge-race-fix
nomisRev Feb 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 66 additions & 17 deletions modules/fx/arrow-fx/src/test/kotlin/arrow/fx/IOTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ import arrow.fx.extensions.io.concurrent.concurrent
import arrow.fx.extensions.io.concurrent.parMapN
import arrow.fx.extensions.io.dispatchers.dispatchers
import arrow.fx.extensions.io.functor.functor
import arrow.fx.extensions.io.monad.flatMap
import arrow.fx.extensions.io.monad.map
import arrow.fx.extensions.io.monad.monad
import arrow.fx.extensions.toIO
import arrow.fx.extensions.toIOException
Expand Down Expand Up @@ -392,8 +390,7 @@ class IOTest : UnitSpec() {
}

fun makePar(num: Long): IO<Nothing, Long> =
IO.concurrent<Nothing>()
.sleep((num * 100).milliseconds)
IO.sleep((num * 100).milliseconds)
.map { num }.order()

val result =
Expand Down Expand Up @@ -632,11 +629,11 @@ class IOTest : UnitSpec() {
val size = 5000

fun ioRacePair(i: Int): IO<Nothing, Int> =
IO.raceN(IO.never, if (i < size) ioRacePair(i + 1) else just(i))
.map {
it.fold(
::identity,
::identity
IO.racePair(IO.dispatchers<Nothing>().default(), IO.never, if (i < size) ioRacePair(i + 1) else just(i))
.map { res ->
res.fold(
{ a, _ -> a },
{ _, b -> b }
)
}

Expand All @@ -647,18 +644,38 @@ class IOTest : UnitSpec() {
val size = 5000

fun ioRaceTriple(i: Int): IO<Nothing, Int> =
IO.raceN(IO.never, IO.never, if (i < size) ioRaceTriple(i + 1) else just(i))
.map {
it.fold(
::identity,
::identity,
::identity
IO.raceTriple(IO.dispatchers<Nothing>().default(), IO.never, IO.never, if (i < size) ioRaceTriple(i + 1) else just(i))
.map { res ->
res.fold(
{ a, _, _ -> a },
{ _, b, _ -> b },
{ _, _, c -> c }
)
}

just(1).flatMap(::ioRaceTriple).unsafeRunSync() shouldBe size
}

"race2 should be stack safe" {
val size = 5000

fun ioRace2(i: Int): IO<Nothing, Int> =
IO.raceN(IO.never, if (i < size) ioRace2(i + 1) else just(i))
.map { it.fold(::identity, ::identity) }

just(1).flatMap(::ioRace2).unsafeRunSync() shouldBe size
}

"race3 should be stack safe" {
val size = 5000

fun ioRace3(i: Int): IO<Nothing, Int> =
IO.raceN(IO.never, IO.never, if (i < size) ioRace3(i + 1) else just(i))
.map { it.fold(::identity, ::identity, ::identity) }

just(1).flatMap(::ioRace3).unsafeRunSync() shouldBe size
}

"IORace4 should be stack safe" {
val size = 5000

Expand Down Expand Up @@ -712,7 +729,7 @@ class IOTest : UnitSpec() {
just(1).flatMap(::ioRace6).unsafeRunSync() shouldBe size
}

"forked pair race should run" {
"forked race2 should run" {
IO.fx<Nothing, Either<Int, Int>> {
IO.raceN(
IO.sleep(10.seconds).followedBy(IO.effect { 1 }),
Expand All @@ -721,7 +738,7 @@ class IOTest : UnitSpec() {
}.unsafeRunSync() shouldBe 3.right()
}

"forked triple race should run" {
"forked race3 should run" {
IO.fx<Nothing, Race3<out Int, out Int, out Int>> {
IO.raceN(
IO.sleep(10.seconds).followedBy(IO.effect { 1 }),
Expand All @@ -731,6 +748,38 @@ class IOTest : UnitSpec() {
}.unsafeRunSync() shouldBe Race3.Third(2)
}

"forked racePair should run" {
IO.fx<Nothing, Int> {
val res = IO.racePair(
IO.dispatchers<Nothing>().default(),
IO.sleep(10.seconds).followedBy(IO.effect { 2 }),
IO.effect { 1 }
).fork().bind().join().bind()

res.fold(
{ a, _ -> a },
{ _, b -> b }
)
}.suspended() shouldBe Right(1)
}

"forked triple racePair should run" {
IO.fx<Nothing, Int> {
val res = IO.raceTriple(
IO.dispatchers<Nothing>().default(),
IO.sleep(1.seconds).followedBy(IO.effect { 1 }),
IO.sleep(2.seconds).followedBy(IO.effect { 3 }),
IO.effect { 2 }
).fork().bind().join().bind()

res.fold(
{ a, _, _ -> a },
{ _, b, _ -> b },
{ _, _, c -> c }
)
}.suspended() shouldBe Right(2)
}

"IOParMap2 should be stack safe" {
val size = 5000

Expand Down