Update Arrow "cancel" wording for consistency #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakoito
approved these changes
Feb 13, 2020
rachelcarmena
pushed a commit
that referenced
this pull request
Feb 24, 2021
* Renaming cancelable to cancellable and similars * Change cancel wording to have 2 Ls for consistency (#2055) * Nits :) * Nits * Remove TO-DOs Co-authored-by: danieh <danimontoya_86@hotmail.com>
rachelcarmena
added a commit
that referenced
this pull request
Feb 24, 2021
* 0.11.0/bio (#1975) * BIO - Part 1 (#1851) * Add E param * Fix imports & types * Add RaiseError case * Refactor IO name * [BIO]: include `E` into IOFrame & IORunLoop (#1859) * Rewrite IOFrame * Update IORunLoop & fix resulting combinators * Move public code to IO.kt * Refactor Right to Success * IO: IOConnection & IOBracket (#1870) * Update ForwardCancelable * Update IOBracket * Remove KindConnection and refactor into IOConnection * IO Concurrency combinators & Green Build (#1892) * BIO - Part 1 (#1851) * Add E param * Fix imports & types * Add RaiseError case * Refactor IO name * [BIO]: include `E` into IOFrame & IORunLoop (#1859) * Rewrite IOFrame * Update IORunLoop & fix resulting combinators * Move public code to IO.kt * Refactor Right to Success * IO: IOConnection & IOBracket (#1870) * Update ForwardCancelable * Update IOBracket * Remove KindConnection and refactor into IOConnection * Rewrite UnsafePromise * Rewrite ParMap2 * Update IOParMap3 * Update IORacePair * Update IORaceTriple * Fix tests * Fix KIO benchmarks * Fix imports Ank * Fix IOExample * Fix unused imports * Fix imports benchmarks * Fix arrow-integrations-retrofit-adapter * Fix FpToTheMax & typeclasses example * KtLintFormat * Fix IOTest * Fix more tests * Fix merge conflicts * KtLintFormat * Fix MaybeK bracket and use it for QueueTest * Throw proper exception in impossible cases * Revert removing runAsync * Fix build * KtLintFormat * Temporary solution for DSL receiver conflict overloads (#1994) * Add fix and test (#2013) * More meaningful functions mapping Either to BIO (#2002) (#2003) * Add missing test and fix merge review changes (#2016) * Change cancel wording to have 2 Ls for consistency (#2055) * Arrow test conflict after merge * Fix benchmarks * Fix build * Fix some errors in tests and code Fix L spelling of cancellable * Conf: separate 0.11.0 version * Merge fixes * Merge fixes * Fix package for eq (#135) * Fix doc generation and validation failures (#132) Co-authored-by: nomisRev <vergauwen.simon@gmail.com> Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> * After release 0.10.5: just considering one wip version (#133) Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> Co-authored-by: Simon Vergauwen <vergauwen.simon@gmail.com> Co-authored-by: Paco <pakoito@users.noreply.github.com> Co-authored-by: Oskar Drozda <themppsplx@gmail.com> Co-authored-by: Alberto Ballano <aballano@users.noreply.github.com> Co-authored-by: raulraja <raulraja@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change cancel wording to have 2 Ls for consistency