-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comonad laws #214
Comonad laws #214
Conversation
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
=========================================
Coverage ? 51.33%
Complexity ? 205
=========================================
Files ? 99
Lines ? 2168
Branches ? 264
=========================================
Hits ? 1113
Misses ? 947
Partials ? 108
Continue to review full report at Codecov.
|
Law("Traverse Laws: Parallel composition", { parallelComposition(TF, { AF.pure(it) }, EQ) }), | ||
Law("Traverse Laws: FoldMap derived", { foldMapDerived(TF, { AF.pure(it) }) }) | ||
) | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this commented code get removed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it has to be re-enabled after the issue in the fixme is fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, it's gonna be fixed prior to merging this or in a different PR ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an issue on the Kotlin compiler, I may need to add a reference to it: https://youtrack.jetbrains.com/issue/KT-18660
Co-authored-by: Jorge Castillo <jorge.castillo.prz@gmail.com>
Co-authored-by: emacolombo <emanuele.colombo@lastminute.com>
This diff adds laws for Comonad, along with tests for all instances.
Turns out Cofree was correctly implemented after all. Huh.