Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comonad laws #214

Merged
merged 7 commits into from
Aug 20, 2017
Merged

Comonad laws #214

merged 7 commits into from
Aug 20, 2017

Conversation

pakoito
Copy link
Member

@pakoito pakoito commented Aug 19, 2017

This diff adds laws for Comonad, along with tests for all instances.

Turns out Cofree was correctly implemented after all. Huh.

@pakoito pakoito requested review from raulraja, JorgeCastilloPrz and a team August 19, 2017 01:04
@pakoito pakoito mentioned this pull request Aug 19, 2017
54 tasks
@codecov-io
Copy link

codecov-io commented Aug 19, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@07abfa0). Click here to learn what that means.
The diff coverage is 1.92%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #214   +/-   ##
=========================================
  Coverage          ?   51.33%           
  Complexity        ?      205           
=========================================
  Files             ?       99           
  Lines             ?     2168           
  Branches          ?      264           
=========================================
  Hits              ?     1113           
  Misses            ?      947           
  Partials          ?      108
Impacted Files Coverage Δ Complexity Δ
...test/src/main/kotlin/kategory/laws/TraverseLaws.kt 8.33% <0%> (ø) 1 <0> (?)
...-test/src/main/kotlin/kategory/laws/ComonadLaws.kt 2.56% <2.56%> (ø) 1 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07abfa0...9f2514a. Read the comment docs.

Law("Traverse Laws: Parallel composition", { parallelComposition(TF, { AF.pure(it) }, EQ) }),
Law("Traverse Laws: FoldMap derived", { foldMapDerived(TF, { AF.pure(it) }) })
)
*/
Copy link
Member

@JorgeCastilloPrz JorgeCastilloPrz Aug 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this commented code get removed ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it has to be re-enabled after the issue in the fixme is fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, it's gonna be fixed prior to merging this or in a different PR ?

Copy link
Member Author

@pakoito pakoito Aug 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an issue on the Kotlin compiler, I may need to add a reference to it: https://youtrack.jetbrains.com/issue/KT-18660

@raulraja raulraja merged commit 4d6ceeb into master Aug 20, 2017
@raulraja raulraja deleted the paco-comonadlaws branch August 20, 2017 16:37
rachelcarmena pushed a commit that referenced this pull request Feb 24, 2021
Co-authored-by: Jorge Castillo <jorge.castillo.prz@gmail.com>
rachelcarmena pushed a commit that referenced this pull request Feb 24, 2021
Co-authored-by: emacolombo <emanuele.colombo@lastminute.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants