Reducible

[JorgeCastilloPrz]

Fixes #211

• Added Reducible and NonEmptyReducible instance.
• Added Reducible laws.
• Added tests for Reducible and ReducibleLaws.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@4d6ceeb). Click here to learn what that means.
The diff coverage is 28.71%.

@@            Coverage Diff            @@
##             master     #215   +/-   ##
=========================================
  Coverage          ?   50.44%           
  Complexity        ?      206           
=========================================
  Files             ?      101           
  Lines             ?     2266           
  Branches          ?      276           
=========================================
  Hits              ?     1143           
  Misses            ?     1011           
  Partials          ?      112

Impacted Files	Coverage Δ	Complexity Δ
kategory/src/main/kotlin/kategory/data/Composed.kt	32.65% <0%> (ø)	0 <0> (?)
...ategory/src/main/kotlin/kategory/typeclasses/Eq.kt	44.44% <0%> (ø)	0 <0> (?)
.../main/kotlin/kategory/instances/ListKWInstances.kt	72.41% <0%> (ø)	0 <0> (?)
.../src/main/kotlin/kategory/generators/Generators.kt	70.83% <100%> (ø)	0 <0> (?)
kategory/src/main/kotlin/kategory/data/ListKW.kt	58.33% <100%> (ø)	1 <0> (?)
kategory/src/main/kotlin/kategory/data/Option.kt	53.12% <100%> (ø)	2 <0> (?)
...y/src/main/kotlin/kategory/typeclasses/Foldable.kt	23.52% <26.31%> (ø)	0 <0> (?)
...est/src/main/kotlin/kategory/laws/ReducibleLaws.kt	3.44% <3.44%> (ø)	1 <1> (?)
.../src/main/kotlin/kategory/typeclasses/Reducible.kt	48.64% <48.64%> (ø)	0 <0> (?)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d6ceeb...8e1f9a5. Read the comment docs.

[raulraja]

🎉

[pakoito]

I'm the waterparties here. The detek baseline will need to be regenerated and the long lines fixed if this is not enforced anymore :P

[JorgeCastilloPrz]

Could enable it again, but detekt was not allowing me to compile in any way (tried many workarounds) because of format requirement collisions on 2 different rules (I think it was this one and MaxLineLength). I didn't have any other choice than disabling this.

[pakoito]

ExpressionBodySyntaxLineBreaks is an auto-fix that's bugged. Instead of applying to every instance, it only applies to the first one per file. You have to run it multiple times to make it work.

Once those errors are gone, you'll get a lot of MaxLineLength ones. For that you just regenerate the baseline with ./gradlew detektEstablishAcceptedErrors and push

[pakoito]

The train of thought is that autofix > MaxLineLength + regenerate baseline, for consistency purposes. It's quite annoying for now, so reverting would mean fixing all the MaxLineLength back. No more than 30 minutes to do it tho.

[JorgeCastilloPrz]

Ok. I've done what we agreed on in slack for this PR:

• Auto-fixed ExpressionBodySyntaxLineBreaks violations with ./gradlew detekt (running it multiple times).
• When I just had a few MaxLineLength violations I regenerated baseline with ./gradlew detektEstablishAcceptedErrors.