CU-ev2g8f Fix Sequence#travserse, Option#apEval & Either#apEval #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: CU-ev2g8f Fix Sequence#traverse |
aballano
approved these changes
Feb 25, 2021
| @@ -1588,7 +1588,7 @@ fun <A, B, C> EitherOf<A, B>.ap(ff: EitherOf<A, (B) -> C>): Either<A, C> = | |||
| flatMap { a -> ff.fix().map { f -> f(a) } } | |||
|
|
|||
| fun <A, B, C> Either<A, B>.apEval(ff: Eval<Either<A, (B) -> C>>): Eval<Either<A, C>> = | |||
| ff.map { this.ap(it) } | |||
| fold({ l -> Eval.now(l.left()) }, { r -> ff.map { it.map { f -> f(r) } } }) | |||
There was a problem hiding this comment.
is there or should be a specific test for this change?
There was a problem hiding this comment.
We should add many tests.. 😭😅 This code was taken from the EitherApply.kt code, and is verified in TraverseTest. By reverting this change it makes TraverseTest fail.
There was a problem hiding this comment.
By reverting this change it makes TraverseTest fail.
That's what I meant, perfect then! 👌
raulraja
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues for traversing an
Sequence.foldRightwithoutEvalwhich first materialises the whole list in memory. This always results in anOOMeven if the transformation oftraverseresults in a short-circuit.apEvalforEitherandOptionto properly short-circuit.