-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cu f31fp2 unify constructors #2278
Conversation
Task linked: CU-f31fp2 Unify constructors |
arrow-libs/core/arrow-core-data/src/main/kotlin/arrow/core/NonEmptyList.kt
Outdated
Show resolved
Hide resolved
arrow-libs/core/arrow-core-data/src/main/kotlin/arrow/core/Ior.kt
Outdated
Show resolved
Hide resolved
Thanks for the awesome reviews @aballano |
Anytime mate 😘 |
arrow-libs/core/arrow-core-data/src/main/kotlin/arrow/core/Option.kt
Outdated
Show resolved
Hide resolved
arrow-libs/core/arrow-core-data/src/main/kotlin/arrow/core/computations/either.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only left a few minor comments. Good job, @nomisRev!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too many files to review. Stamping!
Co-authored-by: Francisco Diaz <francisco.d@47deg.com>
This PR removes the code deprecated in arrow-kt/arrow-core#344.